Draft: Migrate GKE submit button component
What does this MR do and why?
Migrate GKE submit button component to Pajamas GlButton
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
- Open the project where you have maintainers rights OR login as admin
- Apply this patch, otherwise you'd need to connect your local gitlab to gcp token
Patch
diff --git a/app/controllers/clusters/clusters_controller.rb b/app/controllers/clusters/clusters_controller.rb
index 21868cec313..7331af1bcb1 100644
--- a/app/controllers/clusters/clusters_controller.rb
+++ b/app/controllers/clusters/clusters_controller.rb
@@ -52,7 +52,8 @@ def new
@instance_types = load_instance_types.to_json
elsif params[:provider] == 'gcp'
- redirect_to @authorize_url if @authorize_url && !@valid_gcp_token
+ true
+ # redirect_to @authorize_url if @authorize_url && !@valid_gcp_token
end
end
diff --git a/app/views/clusters/clusters/gcp/_new.html.haml b/app/views/clusters/clusters/gcp/_new.html.haml
index 6c3a230fb93..080a715fcdc 100644
--- a/app/views/clusters/clusters/gcp/_new.html.haml
+++ b/app/views/clusters/clusters/gcp/_new.html.haml
@@ -1,5 +1,5 @@
= render 'clusters/clusters/gcp/header'
-- if @valid_gcp_token
+- if true
= render 'clusters/clusters/gcp/form'
- else
= render 'clusters/clusters/gcp/gcp_not_configured'
- Go to Infrastructure -> Kubernetes clusters
- Choose Create a cluster (certificate - deprecated) or open http://localhost:3000/twitter/Typeahead.Js/-/clusters/new?provider=gcp
- Check the
Create Kubernetes cluster
button
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Diana Zubova