Skip to content

Fix CRM Quick Actions Available when Feature Disabled

Lee Tickett requested to merge 2256-fix-observe-crm-enabled into master

@gweaver identified that it the CRM group setting is being ignored in subgroups.

It looks like the change to only support contacts/organizations in root groups inadvertently broke it.

This MR fixes it and adds a spec to prevent regression.

Validation

https://docs.gitlab.com/ee/user/crm/

  1. Enable CRM feature flag for a root group
  2. Enable CRM feature in root group settings
  3. Create 1 or more contacts in the root group (if you've recently installed GDK or reset your db, they will already exist)
  4. Create a subgroup (and ensure the CRM feature is not enabled)
  5. Ensure the /add_contacts and /remove_contacts quick actions work in issues for projects in the root group
  6. Ensure the quick actions do not work for issues in the subgroup

Related to #2256

Merge request reports