Skip to content

Fix infinite activities requests on profile

Peter Hegman requested to merge 323081-scrolling-to-the-bottom-of-the-user-profile-overview-page-triggers-the-infinite-scroll into master

What does this MR do and why?

Related to #323081 (closed)

On a user's profile if you click the activities tab, scroll to the bottom of the page, click the overview tab, and then scroll to the bottom of the page there will be infinite API requests.

Screenshots or screen recordings

Profile page

Before After
Untitled__6_ Untitled__7_

Groups page

Where Pager is used without the container argument (initialized in app/assets/javascripts/pages/groups/activity/index.js#L4). Still works, videos expected to be the same.

Before After
Screen_Recording_2022-04-12_at_2.36.16_PM Untitled__8_

How to set up and validate locally

  1. Sign in and visit your profile.
  2. Open Dev tools and switch to the Network tab
  3. Click the Activities tab and scroll to the bottom to load more activities
  4. Click the Overview tab and scroll to the bottom. The activities API request should not be fired.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Hegman

Merge request reports