Skip to content

GraphQL: Add INVALID enum value to CiRunnerUpgradeStatusType

Pedro Pombeiro requested to merge pedropombeiro/339523/graphql-formalize-invalid-enum-value into master

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR adds the INVALID enum value to Types::Ci::RunnerUpgradeStatusTypeEnum. This value is required because it is a valid return value for Gitlab::Ci::RunnerUpgradeCheck#check_runner_upgrade_status (some runner models have no version value assigned to them). In order to avoid similar situations in the future, I've added a list to Gitlab::Ci::RunnerUpgradeCheck including all the possible statuses. The GraphQL enum is then generated from this list.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #339523 (closed)

Edited by Pedro Pombeiro

Merge request reports