Skip to content

Improve runner edit form design

Miguel Rincon requested to merge 299758-redesign-runner-update-form into master

What does this MR do and why?

This change updates the style and order of runner fields in the runner update form.

Changelog: changed

Related to #299758 (closed)

Limited MR Scope

This MR does not yet implement the visual changes to the projects section of the page. This requires a backend addition at GraphQL API: Extend `runnerUpdate` mutation to ... (#359958 - closed).

Other visual changes are added as an iteration of #299758 (closed)

Screenshots or screen recordings

before after
Screen_Shot_2022-04-21_at_10.08.29 Screen_Shot_2022-04-21_at_10.07.18

New loading state

2022-04-21_10.11.55

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Logged in a admin
  2. Visit the admin runners page Admin -> Runners
  3. Visit any runner edit page (e.g. http://gdk.test:3000/admin/runners/79/edit) by clicking on the pencil icon.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Miguel Rincon

Merge request reports

Loading