Skip to content

Fix url link in vulnerabilities avatar link

Related to #355866 (closed)

What does this MR do and why?

Ensure that <user_avatar_link/> works effectively GlAvatar. Avatar and Link render as expected. Incorrect user attribute fixed so that href now also works as expected.

Screenshots or screen recordings

Chrome

ff off ff on
Screenshot_2022-04-20_at_19.46.21 Screenshot_2022-04-20_at_19.47.43

Chromium, Safari, Edge

ff off ff on
Screenshot_2022-04-21_at_13.49.01 Screenshot_2022-04-21_at_13.51.08

How to set up and validate locally

  1. navigate to a project with vulnerabilities in Vulnerability Report

  2. view security/vulnerability_report

  3. select any vulnerability by clicking on description

  4. change status to confirmed if it is not the current status

  5. component rendered in vulnerability header

  6. Enable new GIAvatar

      Feature.enable(:gl_avatar_for_all_user_avatars)
  7. ensure component still renders correctly

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

RE Testing: The wrong attribute in the user object was being passed, no effective way to test this as data would have to be faked for the test.

Edited by James Rushford

Merge request reports

Loading