Improve shared runner toggle interactions
What does this MR do and why?
Description
This change updates the shared runners settings by removing some elements and improving their loading state.
It adds a more prominent warning for users when their settings cannot be changed.
Changelog: changed
Related to #349794 (closed), #358778 (closed), #330177 (closed)
Why this change?
I started with the intention of adding a few tests to this feature, but I found the current interaction clunky, especially, the loading state.
I took the opportunity to improve these toggles with some newer states provided by gl-toggle.
Screenshots or screen recordings
| before | after |
|---|---|
 |
 |
 |
 |
How to set up and validate locally
Given two groups, one group and one subgroup.
Group can be changed
- Visit Group -> CI/CD Settings
- Enable/disable the toggle in the group to check how the data is stored.
Subgroup cannot be changed
- Enable the "Shared runners" toggle in the group
- Visit Subgroup -> CI/CD Settings
- Confirm the form is disabled in the subgroup.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Miguel Rincon