Raisl 5: Fix Gitlab::Database::LoadBalancing#caught_up? check
requested to merge 8583-rails5-gitlab-database-loadbalancing-caught_up-returns-state-incorrectly into master
What does this MR do?
Rails 5 returns true
or false
instead of a string t
or f
, this MR changes the check to use Gitlab::Utils.to_boolean
to cover all cases.
What are the relevant issue numbers?
Closes #8583 (closed)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
~~Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.~~ -
EE specific content should be in the top level /ee
folder -
For a paid feature, have we considered GitLab.com plans, how it works for groups, and is there a design for promoting it to users who aren't on the correct plan?
Edited by Douglas Barbosa Alexandre