Skip to content

Fix CRM issue search with vue_issues_list

Lee Tickett requested to merge 2256-fix-crm-issue-search into master

What does this MR do and why?

When the vue issues list was introduced it was not built to handle the crm_contact_id and crm_organization_id querystrings.

This fixes that, although not very gracefully (no token/widget has been created yet).

Screenshots or screen recordings

image

image

How to set up and validate locally

https://docs.gitlab.com/ee/user/crm/

From rails console:
1. Enable feature flags:
Feature.enable(:customer_relations)
Feature.enable(:contacts_autocomplete)

If you've recently reseeded your database, you'll have some contacts and organizations created already. Otherwise run:
  bundle exec rake db:seed_fu FILTER=crm

2. Pick a group and enable CRM in group settings (flightjs for example http://gdk.test:3000/groups/flightjs/-/edit)
3. Find a contact in the group who belongs to an organiztion
4. Add the contact to a few issues in the group (with /add_contacts quick action)
5. Visit the group contacts list http://gdk.test:3000/groups/flightjs/-/crm/contacts
6. Click the issues button for the contact and ensure the correct issues are returned
7. Visit the group contacts list http://gdk.test:3000/groups/flightjs/-/crm/organizations
8. Click the issues button for the contact's organization and ensure the correct issues are returned

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lee Tickett

Merge request reports

Loading