Skip to content

Revert custom `is_primary?` logic change from GraphQL TraningType

Mehmet Emin INAC requested to merge revert_80731_manually into master

What does this MR do and why?

This change does not fix anything at all and the specs give us a false positive because we were using the wrong subject(TrainingType is supposed to be working with TrainingProvider not Training).

Context: This change had been introduced by !80731 (merged) which had a different approach in the beginning and we couldn't catch this issue in that MR because we were focused on fixing this ASAP and how bad using the model layer callbacks.

The original issue has already been fixed by another MR anyways: Add primary training support to security traini... (!81204 - merged).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mehmet Emin INAC

Merge request reports