Refactor backup manager specs
What does this MR do and why?
These backup creation specs were stubbing backup_information so that the backup time encoded in the filename was consistent, but this data was supposed to be generated by backup creation itself. In a followup I will be verifying that the backup information is generated correctly.
Here we remove these stubs. Instead of time travelling in every backup test, we have one test to verify the defaults, but moved most tests to use BACKUP, this way we only minimally change the existing tests.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by James Fargher