Update group deletion protection settings interface
What does this MR do and why?
This MR updates the group deletion protection settings to match the designs in #352961 (closed), functionally nothing changes.
It follows the changes in !86568 (merged) that updated the admin settings interface.
Screenshots or screen recordings
Allowed to delete projects
Admins | Owners and administrators |
---|---|
Enabled instance wide
Before | After |
---|---|
Disabled instance wide
Before | After |
---|---|
Enforced for sub-groups
Before | After |
---|---|
How to set up and validate locally
Setup:
- Checkout this branch:
352961-update-group-deletion-protection-settings
- Pick a group with a subgroup, or create a subgroup. I'm using
gitlab-org/gitlab-sub
in this example. - Open a tab for the group Deletion protection settings at: http://localhost:3000/groups/gitlab-org/-/edit#js-permissions-settings
- Open a tab for the subgroup Deletion protection settings at: http://localhost:3000/groups/gitlab-org/gitlab-sub/-/edit#js-permissions-settings
- Open a tab for the admin Deletion protection settings at: http://localhost:3000/admin/application_settings/general#js-visibility-settings
Validation:
- Toggle between the Admin > Allowed to delete projects options and verify that the help text changes under group Deletion protection.
- Check
None, delete immediately
in Admin > Deletion protection verify that the group Deletion protection setting is locked. - Check
Keep deleted groups
with a number of days in Admin > Deletion protection and verify that the Group > Deletion protection setting is unlocked. - Check
Keep deleted groups and projects
in Admin > Deletion protection and create a new group, verify that Group > Deletion protection hasKeep deleted projects
checked. - Check
Enforce deletion protection for all subgroups
in the parent group's Group > Deletion protection settings and verify that the sub-group's setting is locked.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Approvals required
Edited by Jiaan Louw