Lefthook: Do not reveal RuboCop TODOs for HAML lint
What does this MR do and why?
Having REVEAL_RUBOCOP_TODO=1 reveals RuboCop TODOs also for HAML lint
which and sometimes prevents pushing code.
This commit hides any RuboCop TODOs in lefthook also for HAML lint.
This came up during the review of !85427 (comment 930922947).
Refs !56851 (merged)
Screenshots or screen recordings
|
Before |
After |
|---|---|
 |
 |
How to set up and validate locally
- Reveal RuboCop TODOs via
export REVEAL_RUBOCOP_TODO=1 - Create a new branch
git checkout -b test - Make change to a HAML file via
echo >> app/views/projects/buttons/_clone.html.haml - Commit the change
git commit -m "test" app/views/projects/buttons/_clone.html.haml - Run lefthook pre-push via `bundle exec lefthook run pre-push
- Lefthook will fail Before
💥 this change and pass✅ After the change.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Peter Leitzen