Skip to content

Add an empty newline test to Ansi2Json

Harsh Chouraria requested to merge hchouraria-add-missing-empty-newline-test-to-ansi2json into master

What does this MR do and why?

The current behavior of Ansi2Json when it encounters an empty line is to ignore it in the JSON generated.

However, this behavior hasn't been explicitly tested in the unit tests so this change adds a spec for it.

Regardless of this behavior being intentional or a bug a test should be covering it given its observed during use and a change to the behavior must not go unnoticed.

How to set up and validate locally

See issue #217231 where the behavior of empty newlines is discussed with more information on reproducing the issue.

The test added here passes by default, validating the issue above.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports