GitLab logo and hamburger menu should be visible when the Visual Review Toolbar is enabled
Context
When including https://gitlab.com/gitlab-org/visual-review-tools into GitLab (see How to set up and validate locally
section below), some elements of the top-bar menu will disappear.
blocks #340088 (closed) (See the original discussion)
What does this MR do and why?
Fix the CSS, so that the GitLab logo and the hamburger menu are visible at all times when we include the visual-review-toolbar.
Acceptance criteria
The GitLab logo and the menu hamburger are visible in the following possible scenarios:
- When the user is signed-in
- When the user is signed-out
- When the user is on any screen (signed-in and signed-out)
How to set up and validate locally
- Work from a recent
master
branch - Disable all CSP by commenting out all of the
Rails.application.config.content_security_policy
lines inconfig/initializers/content_security_policy.rb
- Add the following script at the end of
app/views/layouts/application.html.haml
:
<script data-merge-request-id="6" data-mr-url="https://gitlab.com" data-project-id="278964" data-project-path="gitlab-org/gitlab" data-require-auth="false" id="review-app-toolbar-script" src="https://gitlab.com/assets/webpack/visual_review_toolbar.js"></script>
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.