Skip to content

Refactor to use let! in vulnerability_management_spec

Harsha Muralidhar requested to merge hmuralidhar-use-let-for-fabrication into master

What does this MR do and why?

This MR refactors vulnerability_management_spec in secure to use rspec let! instead of instance variables for resource fabrication. This is one of the action items from https://gitlab.com/gitlab-org/quality/team-tasks/-/issues/1232

How to set up and validate locally

Run against GDK with this command:

GITLAB_QA_ACCESS_TOKEN=XXXXXXXX GITLAB_PASSWORD="XXXXXXXX" QA_DEBUG=true CHROME_HEADLESS=false bundle exec bin/qa Test::Instance::All http://192.168.1.105:3000 ./qa/specs/features/ee/browser_ui/13_secure/vulnerability_management_spec.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Tiffany Rea

Merge request reports