Skip to content

Remove unnecessary ExecStop from sidekiq service file

Jörg Behrmann requested to merge behrmann/gitlab:sidekiqexecstop into master

What does this MR do and why?

This removes an unnecessary ExecStop= from the gitlab-sidekiq.service file for self-hosted installations.

I noticed that stopping GitLab 14.10 left gitlab-sidekiq.service in a failed state, since sidekiqctl was not installed. I'm pretty sure this used to work before, but haven't followed up. It doesn't pose a problem, it is mostly a cosmetic thing, but I saw that upstream doesn't put on into its example service file.

How to set up and validate locally

  1. Install a self-hosted GitLab instance
  2. Update the gitlab-sidekiq.service
  3. Start GitLab
  4. Stop GitLab
  5. see that gitlab-sidekiq.service is not in the output of systemctl list-units --failed (Workhorse will be in there, this is a known issue I'm looking into)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports