Fix vulnerability report project filter loading icon
What does this MR do and why?
This MR fixes some issues with the loading spinner for the project filter on the group and instance vulnerability reports:
 |
- Previously, when doing a search and the next page of results was being loaded, the entire list was replaced with a spinner instead of just showing a spinner at the bottom. This has been fixed:
| Before | After |
|---|---|
| Peek_2022-05-26_17-20 | Peek_2022-05-26_17-30 |
- Previously, two different loading spinners were used, depending on whether the first page of results is being loaded (larger spinner) or additional pages are (smaller spinner at the bottom of the dropdown). The logic to manage this was a small nightmare to maintain, so it has been replaced with a single smaller spinner that's shown for both. This also affects the All options item, which is now shown for the first page load, whereas it wasn't before:
| Before | After |
|---|---|
| Peek_2022-05-26_17-23 | Peek_2022-05-26_17-31 |
- Previously, the loading spinner was added to the bottom of the page only when the next page of results was being loaded. This causes the dropdown scroll position to jump a little when the spinner is shown. Now, the spinner is always at the bottom of the list, but it's not visible until the page is loading, which prevents the jump:
| Before | After |
|---|---|
| Peek_2022-05-26_17-28 | Peek_2022-05-26_17-33 |
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #356327 (closed)
Edited by Daniel Tian