Skip to content

Clarify MR message when missing required approvals

Pedro Moreira da Silva requested to merge pms-approvals-missing-message into master

What does this MR do and why?

When an MR is blocked because it's missing required approvals, we say this merge request must be approved but the approvals widget says Requires X approvals. What’s missing is the notion of number of required approvals. This MR aims to make that messages clearer.

How to set up and validate locally

  1. Setup required approvals in a project.
  2. Create an MR.
  3. Check the merge widget for the “Merge blocked…” message.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports