Skip to content

Updating Line Ambiguity

Ryan Castro requested to merge rcastro6-saml-update into master

What does this MR do and why?

The current text of the doc says to add a new line "immediately after the class line" but the lines subsequent to the class line have several includes and putting that line in front of then causes errors.

Changing this text to "immediately before verify_known_sign_in" will make it more clear where the line needs to go.

Screenshots or screen recordings

Immediately after class but before the includes. Causes an error when Puma is restarted. image

After the includes but before the verify_known_sign_in line. No error. image

How to set up and validate locally

Follow instructions in this troubleshooting doc with the skip_before_action :verify_authenticity_token line on line 4 and restart Puma - error.

Put skip_before_action :verify_authenticity_token on line 10 and restart Puma - no error

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports