Skip to content

Refactor RegistrationToken Vue component

Eduardo Sanz García requested to merge eduardosanz/registration-dropdown-simplification into master

What does this MR do and why?

This minor refactor accomplish two purposes:

  • Simplifies markdown: before there were two GlFormGroup components, a parent GlFormGroup wrapping a child GlFormGroup. The parent was unnecesary, because RegistrationToken uses InputCopyToggleVisibility, which contains its own GlFromGroup.

  • Allows to select the input content by clicking on the label. Suggested here: !88059 (comment 964374052)

Screenshots or screen recordings

Screen_Recording_2022-05-30_at_15.43.36

How to set up and validate locally

  1. Go to http://127.0.0.1:3000/groups/flightjs/-/runners
  2. Click on the Register a group runner button

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Eduardo Sanz García

Merge request reports