Danger review roulette for strictly needed CODEOWNERS approvals
What does this MR do and why?
This requires: gitlab-org/ruby/gems/gitlab-dangerfiles!130 (merged)
This will look at the merge request approvals, listing strictly required approvals (approvals_required > 0) in the Danger roulette table.
It'll randomly pick one from the eligible_approvers list. It also follows regular roulette rules that excluding unavailable people and stick to the same candidate unless they become unavailable.
TODO:
-
Add tests in gitlab-org/ruby/gems/gitlab-dangerfiles!130 (merged) -
Make this look nicer? We don't know which labels to use for the approval section/name -
Drop the commit that added dummy changes and pointing to a branch in gitlab-dangerfiles -
Release a new version for gitlab-org/ruby/gems/gitlab-dangerfiles!130 (merged) and use it in Gemfile
Screenshots or screen recordings
Approvals widget
Danger roulette table
How to set up and validate locally
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #360840 (closed)
Feedback issue: gitlab-org/quality/engineering-productivity/team#57 (closed)
Edited by Lin Jen-Shin