Skip to content

Adding guest overage modal

Laura Callahan requested to merge 363498-overage-modal into master

What does this MR do and why?

This introduces the guest overage modal without data flow.

To break up the logic behind the modal, I opted to create a "dummy" modal that will show any time the dropdown changes value. The seat overage value and company name are also placeholders.

All of this work is behind the show_overage_on_role_promotion feature flag.

Resolves part of #363498 (closed)

Screenshots or screen recordings

Screen_Shot_2022-06-28_at_1.12.53_PM

How to set up and validate locally

  • Open up the rails console rails c and enable the show_overage_on_role_promotion flag (Feature.enable(:show_overage_on_role_promotion))
  • Navigate to the project members page for a project (ex: gitlab-org/gitlab-shell/-/project_members)
  • Change the Max role value, the modal should appear
    • Clicking off of the modal or clicking "Back" should close the modal
    • Clicking "Continue" will also close the modal (will be updated in a follow up)
  • Clicking the "Learn more" link should open a help page in a new tab
  • Open the dropdown and re-select the current Max role value. The modal should not appear

  • Disable the feature flag (Feature.disable(:show_overage_on_role_promotion))
  • Ensure that the modal does not appear when changing the Max role

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #363498 (closed)

Edited by Laura Callahan

Merge request reports

Loading