Skip to content

Migrates skeleton loader in security dashboard table row

Artur Fedorov requested to merge 363773-security-dashboard-loader into master

What does this MR do and why?

This MR resolves #363773 (closed)

Migrates skeleton loader in security dashboard table row to newer @gitlab/ui loader

Describe in detail what your merge request does and why.

These are strongly recommended to assist reviewers and reduce the time to merge your change.

Screenshots

before
before
after
Screenshot_2022-07-06_at_16.47.27

How to set up and validate locally

Hard way

  1. Go to URL/root/PROJECT_ID/
  2. Go to URL/root/PROJECT_ID/-/pipelines
  3. Open pipeline details
  4. Open security report tab
  5. Prerequisites are to have one of the security jobs in pipeline and have local runner installed

Easier way

  1. Use review apps
  2. Go to this project in deployed branch
  3. You can compare loaders before in this project

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Artur Fedorov

Merge request reports

Loading