Skip to content

Convert Admin users/groups edit/create pages to be Pajamas compliant

What does this MR do and why?

Related to #361999 (closed) and #361998 (closed)

The edit/create pages in Admin -> Users and Admin -> Groups are not currently Pajamas compliant. This MR updates the HTML so that these pages are Pajamas compliant. Originally I was going to update Admin -> Users and Admin -> Groups in separate MRs but I realized there are some HAML partials that are shared between the two pages. This caused issues because if you update the HAML partial for one page it looks weird in the other page. It seemed easier (and better) to update both pages instead of trying to add some sort of argument to the HAML partial to conditionally change the styling.

Screenshots or screen recordings

Admin users edit

Mobile

Before After
gdk.test_3000_admin_users_namespace1_edit__3_ gdk.test_3000_admin_users_namespace1_edit__1_

Desktop

Before After
gdk.test_3000_admin_users_namespace1_edit__2_ gdk.test_3000_admin_users_namespace1_edit

Admin users create

Mobile

Before After
gdk.test_3000_admin_users_new__3_ gdk.test_3000_admin_users_new__1_

Desktop

Before After
gdk.test_3000_admin_users_new__2_ gdk.test_3000_admin_users_new

Admin groups edit

Mobile

Before After
gdk.test_3000_admin_groups_twitter_edit__3_ gdk.test_3000_admin_groups_twitter_edit__1_

Desktop

Before After
gdk.test_3000_admin_groups_twitter_edit__2_ gdk.test_3000_admin_groups_twitter_edit

Admin groups create

Mobile

Before After
gdk.test_3000_admin_groups_new__3_ gdk.test_3000_admin_groups_new__1_

Desktop

Before After
gdk.test_3000_admin_groups_new__2_ gdk.test_3000_admin_groups_new

How to set up and validate locally

Navigate to the following urls:

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Hegman

Merge request reports

Loading