Convert Admin users/groups edit/create pages to be Pajamas compliant
What does this MR do and why?
Related to #361999 (closed) and #361998 (closed)
The edit/create pages in Admin -> Users
and Admin -> Groups
are not currently Pajamas compliant. This MR updates the HTML so that these pages are Pajamas compliant. Originally I was going to update Admin -> Users
and Admin -> Groups
in separate MRs but I realized there are some HAML partials that are shared between the two pages. This caused issues because if you update the HAML partial for one page it looks weird in the other page. It seemed easier (and better) to update both pages instead of trying to add some sort of argument to the HAML partial to conditionally change the styling.
Screenshots or screen recordings
Admin users edit
Mobile
Before | After |
---|---|
Desktop
Before | After |
---|---|
Admin users create
Mobile
Before | After |
---|---|
Desktop
Before | After |
---|---|
Admin groups edit
Mobile
Before | After |
---|---|
Desktop
Before | After |
---|---|
Admin groups create
Mobile
Before | After |
---|---|
Desktop
Before | After |
---|---|
How to set up and validate locally
Navigate to the following urls:
- http://gdk.test:3000/admin/users/new
- http://gdk.test:3000/admin/groups/new
- http://gdk.test:3000/admin/users/root/edit
- http://gdk.test:3000/admin/groups/twitter/edit
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.