Skip to content

Fix namespace_id being lost for github import

Illya Klymov requested to merge xanf-fix-github-namespace-id-missing into master

What does this MR do and why?

This MR ensures we're passing namespace_id to github importer when importing project via subgroup

Related issues:

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Create new access token on github https://github.com/settings/tokens/new
  2. Open any group on your installation (for example jashkenas for default GDK installation)
  3. Click New project -> Import project
  4. Verify that Github button includes namespace_id (for example /import/github/new?namespace_id=29)

(next steps are optional and verify actual functionality)

  1. Click GitHub link and use your access token
  2. Verify that namespace_id is present in URL
  3. Verify that default group in dropdown is selected to group you've used to initiate project creation

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading