Skip to content

Show meaningful error when a CI record is created in main database during test

Albert requested to merge alberts-warn-ci-table-migration-helper into master

What does this MR do and why?

In migration test, we require to use table instead of FactoryBot. The table method defaults to :main database. If it is used for a CI record without specifying database: :ci, the records will be created in :main database. When the code under test looks for records in :ci database, it would fail because it cannot find any records, resulting in a misleading test failure.

Raising an error would help the developer to identify what went wrong more easily.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Albert

Merge request reports

Loading