Updates consumer files to address lint issues

What does this MR do and why?

The consumer tests have some jslint offences that are being ignored through .eslintignore but they still produce a warning. When trying to push in code, lefthook doesn't allow any warnings so jslint fails anyway. This MR removes consumer tests from .estlintignore and addresses the lint issues instead.

The package.json will eventually be merged with the one in root which would have made the config changes here unnecessary as root one already has it configured but there were other additional complications when attempting to merge them and the tests ended up failing so I've left that as a separate issue. (Reference: #364126 (closed)). This will allow us to parallelize the work to resolve this issue and move forward with the OKR to pilot contract tests with a few SETs.

Related: #364547 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.