Skip to content

gitaly_client: Stop checking deprecated git error in UserSquash

Patrick Steinhardt requested to merge pks-gitaly-user-squash-remove-git-error into master

What does this MR do and why?

Gitaly has migrated UserSquash to use structured errors instead of returning errors via a valid response. This new calling convention was unconditionally enabled upstream via e8413304d (operations: Always use structured errors for UserSquash, 2022-03-21), which means that the git_error response field is never set anymore.

Stop checking for presence of this field so that Gitaly can finally remove it altogether.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports