Migrate edit profile errors to use Pajamas compliant alert
requested to merge 364994-migrate-form_errors-in-app-views-profiles-show-html-haml-to-pajamas-alertcomponent into master
What does this MR do and why?
Related to #364994 (closed)
Migrates form error alerts in edit profile page to be Pajamas compliant. There are two ways that alerts are shown on this page.
- When the page is submitted via ajax in app/assets/javascripts/profile/profile.js#L87
- When the page is submitted not via Ajax and hits app/controllers/profiles_controller.rb#L36
- This happens when changing your email because a password confirmation modal is shown and submits the form not via Ajax
- This is not yet Pajamas compliant and will be updated in !89883 (closed)
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
- Navigate to http://gdk.test:3000/-/profile
- Enter
jlkfsdjdlf
in theWebsite url
field - Submit the form
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Peter Hegman