Skip to content

Change the revoke button to type `tertiary`

Eduardo Sanz García requested to merge eduardosanz/revoke-button-tertiary into master

What does this MR do and why?

We decided this change was better than these two other proposals:

In the AccessTokenTableApp component, users may not understand why some access tokens have a primary revoke button (background red), while other access tokens have a secondary (transparent background).

Originally, I believe the primary|secondary buttons were meant to match the color of the text of the Expires column (3 colors: red for expired token, orange for soon-to-be-expired, black for tokens without expiration). However, the match for the button was not perfect: primary button for tokens with expiration, secondary button for tokens without expiration.

This MR changes the revoke buttons to be of type tertiary.

Screenshots or screen recordings

Before After
image__1_ image

How to set up and validate locally

Create a number of personal access tokens with different expiration dates in http://127.0.0.1:3000/-/profile/personal_access_tokens

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading