Skip to content

Use new Dast Profiles Configurator for CI/CD Security configuration

Artur Fedorov requested to merge 365145-dast-profiles-configurator-ci-cd into master

What does this MR do and why?

This MR resolves #365145 (closed) This should be merged after#364123 (closed)

New scanner and site profiles selectors together with new create/edit/select flow from the sidebar are used in On Demand Scans Form

According to new design , same flow has to be used in security configuration enabling DAST form.

Based on that requirement shared functionality was moved to dast_profiles_configurator.vue component and was successfully reused in both

ee/app/assets/javascripts/security_configuration/dast/components/configuration_form.vue and

ee/app/assets/javascripts/on_demand_scans_form/components/on_demand_scans_form.vue

It is now behind feature flag and as soon it is rolled out, extra code marked with TODOs can be removed from on_demand_scans_form in next iteration

Describe in detail what your merge request does and why.

Screenshots or screen recordings

before
Screenshot_2022-06-09_at_01.53.25
after
config

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

  1. Enable feature flag
   Feature.enable(:dast_ui_redesign)
  1. And Go to URL/root/PROJECT_ID/-/security/configuration/dast

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Artur Fedorov

Merge request reports

Loading