Skip to content

Consider patches for eligible runner releases

Pedro Pombeiro requested to merge pedropombeiro/358406/allow-patch-upgrades into master

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR tweaks the logic that checks which Runner releases are available when comparing a given Runner version to see if an upgrade is available. So if a patch release of the Runner is available within the same minor version of the GitLab instance, it will be considered.

A new spec demonstrates the scenario we're covering here. If we have

  • a GitLab instance on 14.0.1
  • a runner on 14.1.0
  • an existing Runner release with version 14.1.1

then we should return :recommended from check_runner_upgrade_status instead of :not_available because even though the runner is above the GitLab instance version, we still want to consider a patch release that could potentially fix an important security issue.

Part of #358406 (closed)

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

The logic is being tested in the updated unit test.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Pedro Pombeiro

Merge request reports