Migrate design resolved discussions to an accordion
What does this MR do and why?
This MR depends on gitlab-ui!2880 (merged) being merged first.
#241555 (closed) was meant to audit a link
button usage in app/assets/javascripts/design_management/components/design_sidebar.vue
to determine whether it could be replaced with some other button variant.
This particular link
button controls a collapsible element build with GlCollapse
and we ended up deciding that the whole thing should be migrated to GlAccordion
. We also decided to get rid of the popover that used to show up when a user first comes across a design that has resolved discussions.
Screenshots or screen recordings
Popover
This popover is being removed altogether. This is what it looked like. |
---|
Collapsible discussions
Before | After | |
---|---|---|
Collapsed | ||
Expanded |
How to set up and validate locally
- Pull this branch and run
yarn
(this relies on a development build of@gitlab/ui
). - Navigate to any issue.
- Attach a design to it and open it.
- Start a discussion and resolve it.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #241555 (closed)
Edited by Paul Gascou-Vaillancourt