Skip to content

Support pages for view prior blame links in paginated mode

Vasilii Iakliushin requested to merge 361747_file_blame_line_detection into master

What does this MR do and why?

Contributes to #225174 (closed)

Problem

When blame view is paginated, the click on "View blame prior to change" redirects us to the first page.

Solution

Provide page parameter to the link and redirect users to the right page.

Screenshots or screen recordings

Before click Redirected page
Screenshot_2022-06-17_at_16.54.52 Screenshot_2022-06-17_at_16.55.02

How to set up and validate locally

  1. Enable feature flag Feature.enable(:blame_page_pagination)
  2. Find a file with more than 1000 lines (or make the PER_PAGE limit lower)
  3. Go to the second page
  4. Click on View blame prior to this change icon next to the commit
  5. Verify that you are redirected to the correct page

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Vasilii Iakliushin

Merge request reports

Loading