Skip to content

Use approvers information which are available through graphql

Zamir Martins requested to merge replace_yaml_info_with_persisted_data into master

What does this MR do and why?

Use approvers information which are available through graphql in order to expand user and group in scan result policies related pages.

Follow-up from backend related MR: !90742 (merged)

UX related discussion: #357301 (comment 997950131)

Related issue: #357301 (closed)

Screenshots or screen recordings

Policy details (Security & Compliance -> Policies)

Screen_Shot_2022-07-06_at_11.43.08_AM

Security Approvals (Project settings -> General -> Merge Request Approvals)

Screen_Shot_2022-07-06_at_11.42.51_AM

How to set up and validate locally

  1. Go to Security & Compliance -> Policies and create a scan result policies as per our docs with at least one approver.
  2. Once again back in Security & Compliance -> Policies, click on the scan result policy and the policy drawer will be visible.
  3. Go to project settings -> general -> merge request approvals and expand the information related to the scan result policy just created.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Zamir Martins

Merge request reports

Loading