Skip to content

Draft: Block accidental usage of destroy or destroy_all on `Ci::JobArtifact` and `Upload`

Michael Kozono requested to merge mk/fix-artifacts-and-uploads-fast-destroy into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Includes FastDestroyAll on Ci::JobArtifact and Upload, as intended.

These models already implement the interface for parent objects to perform fast destroys. But it seems we forgot to include the module, which would additionally:

  • Block accidental usages of destroy or destroy_all, for either data integrity or performance reasons, or both
  • Implement fast_destroy_all on the models. This came up when support needed to destroy some job artifacts, and found that this method was missing. Slack conversation (internal)

Related to #365664

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

No behavior change is expected.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Michael Kozono

Merge request reports