Skip to content

EE Application Settings General h4 Expand/Collapse

Daniel Schömer requested to merge quatauta/gitlab-contrib:ee-admin-app-settings-general-header-expand-click-tap into master

What does this MR do and why?

This MR updates section headers in Admin / Application Settings / General of GitLab Enterprise Edition to expand/collapse on click/tap.

CSS classes settings-title, js-settings-toggle and js-settings-toggle-trigger-only are added to header/h4 elements. This enables the expand/collapse behavior on on-click / on-tap.

Project Settings headers (h4 elements) expand/collapse on mouse-click / tap and using the Expand/Collapse button. Most h4 headers in Admin / Application Settings pages do not expand/collapse on mouse-click / tap, but only using the Expand/Collapse button. This may seem inconsistent to the user.

Screenshots or screen recordings

(The screen recording shows the effect of !90545 (merged). I do not have a GitLab EE license available for testing.)

Screen_Recording_2022-06-17_at_22.29.04

How to set up and validate locally

  1. Start GitLab locally, or in GitPod
  2. Open GitLab Admin / Application Settings / General (e.g. locally at http://127.0.0.1:3000/admin/application_settings/general)
  3. Click or tap a h4 header, e.g. Visibility and access controls
  4. The section will expand / collapse

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Daniel Schömer

Merge request reports