Skip to content

Accept runner patch upgrades from newer major releases

Pedro Pombeiro requested to merge pedropombeiro/358406/2-accept-patch-upgrades-from-newer-major-releases into master

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR fixes a minor bug in the logic of Gitlab::Ci::RunnerUpgradeCheck. If a runner is already on a newer release that is ahead of the GitLab instance version, the upgrade should be considered as :recommended even if the major version does not match. This is because the patch release might contain security fixes and should not have incompatible changes.

Part of GraphQL: Expose filter on GitLab Runner upgrade... (#358406 - closed)

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

New specs were added to exercise the new logic.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Pedro Pombeiro

Merge request reports