Skip to content

Update gitaly_cgroups metric name in docs

John Cai requested to merge jc-docs-update-cgroups-memory-killed-metric into master

What does this MR do and why?

Update gitaly_cgroups metric name

The gitaly_cgroup_memory_failed_total metric name is actually a misnomer. It is, more accurately, the number of memory reclaim attempts that cgroups makes. Rename this metric to be more accurate.

gitaly!4619 (merged) is the Gitaly MR that makes this change.

Also, the feature flags note on cgroups is in the wrong place and doesn't quite communicate the right thing. The feature flag in fact controls whether or not cgroups works at all. Move this bit up higher to make it clearer that the feature flag turns the whole cgroups feature on/off rather than just the new configuration method.

Changelog: changed

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by John Cai

Merge request reports