Skip to content

Fix: notify locale on successful pipeline

What does this MR do and why?

Reason

Right now the email template for successful pipeline notification can only be sent in English

Result

in this MR I updated the template with i18n enabled strings instead of hardcoded strings. After this MR it will be able to send languages the user prefers.

/cc @prajnamas @orozot @qk44077907

Screenshots for change

Triggered by API

CleanShot_2022-06-22_at_11.35.41_2x

Triggered on demand

CleanShot_2022-06-22_at_11.26.38_2x

You may visit this link on your local instance:

http://[your.gdk.com]/rails/mailers/notify/pipeline_success_email

You might not be able to see the screenshot that was not triggered by API, you need to find any available project on your gdk and manually trigger a pipeline (even though it will not run) then refresh the page you can see the updates.

Describe in detail what your merge request does and why.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Wu Jeremy

Merge request reports

Loading