Skip to content

Bring back dependency building for chart review app

DJ Mountney requested to merge review-app-dependency-build into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Bumps the chart SHA used by review-deploy to be newer than gitlab-org/charts/gitlab!2607 (merged) which added support for pulling older bitnami charts as dependencies and dropped the bundled charts approach. I went with a newer commit than that, I went with the commit from master that is currently fully rolled out to gitlab.com as of Jul 6th.

This also brings back the dependency build command (earlier removed in !88977 (merged)), as we dropped the checked in dependencies when using the git checkout of the helm chart (as to not be committing compressed binaries into git).

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Rémy Coutable

Merge request reports

Loading