Skip to content

Add terminating newline to /:username.keys and /:username.gpg

Bogdan Denkovych requested to merge add-terminating-newline-to-ssh-and-gpg-key-list-response into master

What does this MR do and why?

This change makes the output compliant with POSIX 3.206 (which defines a line as a sequence of non-newline characters plus a terminating newline character) and RFC 4880 section 6.2 (which specifies that the terminating newline is to be considered part of the ASCII armored key), respectively, for improved interoperability, e.g. when adding to authorized_keys files.

This MR is taking over a community merge request: !89300 (closed) We need to rebase the branch with the latest master to fix the CI and apply some optimization-related changes.

Note that this MR consists of 2 commits intentionally to retain the author of the original MR to give credit for their work.

Closes !89300 (closed)

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Bogdan Denkovych

Merge request reports