Skip to content

Fix LDAP sign in button padding

David O'Regan requested to merge 366251-ldap-sign-in-button-margin into master

What does this MR do and why?

A tiny MVC for https://gitlab.com/gitlab-org/gitlab/-/issues/366251 to fix the broken bottom padding in the LDAP sign-in container. We fix the issue by simply adding gl-pb-5 to the submit container.

Screenshots or screen recordings

Before After
Screenshot_2022-06-24_at_14.55.00 Screenshot_2022-06-24_at_14.57.34

How to set up and validate locally

  1. Enable LDAP inside your GDK via your config

      # config/gitlab.yml
        development:
          ldap:
          enabled: true
           servers:
             main:
             label: ldap
             host: 127.0.0.1
             port: 3890
             uid: 'uid'
             base: 'dc=example,dc=com'
            ...
  2. Navigate to the sign-in page

  3. Validate the position of the sign-in button.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #366251 (closed)

Edited by David O'Regan

Merge request reports

Loading