Skip to content

Use dangers to remind user to check migrations

Alex Ives requested to merge add_notice_to_run_pipeline into master

What does this MR do and why?

Update danger so that it reminds folks to run the migration testing pipeline. Also calling to_set on the list of files because I can't quite understand why it's outputting duplicates. Also should fix files in db/docs not getting documentation review.

Related to #328367

How to set up and validate locally

  1. Comment out danger/database/Dangerfile Line 57 return unless helper.ci?
  2. Generate a migration file with rails g migration SomeRandomMigration
  3. Run bin/rake danger_local and see that the output says to kick off the migration testing pipeline.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Alex Ives

Merge request reports