Skip to content

Remove code for trigger job show page

Mireya Andres requested to merge cleanup-trigger-job-page into master

What does this MR do and why?

This removes the code for the bridge job page, since we will no longer be developing this feature.

It looks like a big diff, but the changes are mostly just:

  • Removing the code from spec/frontend/jobs/bridge/app_spec.js and the corresponding tests in app/assets/javascripts/jobs/index.js
  • Removing the conditional to render the bridge job page.
  • Removing the trigger_job_retry_action feature flag (currently not enabled or used; feature already exists in production through the pipeline graph)
  • Re-generating translation texts.

Since this removes code from a feature flag disabled by default, no changelog trailers were added to the commit message.

Screenshots or screen recordings

No visual changes from normal.

Screen_Recording_2022-07-05_at_17.58.37

How to set up and validate locally

  1. Setup your .gitlab-ci.yml to trigger a downstream pipeline.
  2. Wait for the pipeline to finish running.
  3. Visit the pipeline graph then click on the trigger job. It should still lead back to downstream pipeline.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mireya Andres

Merge request reports

Loading