Fix avatars displaying as block elements
What does this MR do and why?
This MR fixes avatars displaying as block elements, which was accidentally caused by !90925 (merged).
With !90925 (merged), avatars started displaying as block elements after they were
updated with display: flow-root
. This created a BFC which
we wanted in order to contain the floated avatars to fix the avatar focus rings. However,
this makes the element a block. We can make the element
inline instead with a BFC with display: inline-block
.
Changelog: fixed
Screenshots or screen recordings
before | after |
---|---|
How to set up and validate locally
- Check an epic page and confirm the author in the header does not render on a new line
- Check an MR page with eligible approvers and confirm the avatars are on the same line
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Coung Ngo