Skip to content

Require String attribute_name in keyset pagination

Adam Hegyi requested to merge 325323-fix-keyset-order-attribute-name into master

What does this MR do and why?

This MR requires String attribute_name argument for keyset pagination. Often times a Symbol was passed which in rare cases it might not work properly when the keyset cursor attributes are parsed and generated.

Note: in the docs we already use string keys (https://docs.gitlab.com/ee/development/database/keyset_pagination.html#complex-order-configuration)

Example: #325323 (closed)

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #325323 (closed)

Merge request reports