Skip to content

Draft: Fix warning when user is unable to create project

Eduardo Sanz García requested to merge eduardosanz/warning-max-project-reached into master

What does this MR do and why?

A vague warning, Namespace is not valid, was shown if a user tries to create a project when his maximum number of projects has been reached. After this change, a more specific warning, You've already reached the maximum number of projects you can create in your namespace. Delete unused projects or contact your GitLab administrator., is shown.

This change assumes that current_user.can?(:create_projects, parent_namespace) only check for the condition projects_limit_left > 0. See https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/models/user.rb#L1184. If additional checks are performed on top of this one, I would suggest to drop this MR and perform a more specific check.

Screenshots or screen recordings

Before

image

After

image

How to set up and validate locally

  1. As an admin, go to the users table, select user X, click on the Edit and set the Projects limit to zero.
  2. As user X, try to create a project

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Eduardo Sanz García

Merge request reports