Skip to content

Parse GitLab Runner release version suffixes

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR ensures that GitLab Runner versions parsed from the releases feed retain the version suffix (such as '-rc1'), after this support was added in !90904 (merged).

Part of GraphQL: Expose filter on GitLab Runner upgrade... (#358406 - closed)

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

The tests should be enough to demonstrate that the change works as expected. It is also possible to see it in the GDK console:

Gitlab::Ci::RunnerReleases.instance.releases
=> [#<Gitlab::VersionInfo:0x0000000161bb4b00 @major=14, @minor=3, @patch=2, @suffix_s="">,
 #<Gitlab::VersionInfo:0x0000000161bb4c40 @major=14, @minor=4, @patch=0, @suffix_s="-rc1">,
 #<Gitlab::VersionInfo:0x0000000161bb4d80 @major=14, @minor=4, @patch=0, @suffix=[], @suffix_s="">,
 #<Gitlab::VersionInfo:0x0000000161bb4ec0 @major=14, @minor=5, @patch=0, @suffix_s="-rc1">,
 #<Gitlab::VersionInfo:0x0000000161bb5000 @major=14, @minor=5, @patch=0, @suffix=[], @suffix_s="">,
 #<Gitlab::VersionInfo:0x0000000161bb5140 @major=14, @minor=6, @patch=0, @suffix_s="">,
 #<Gitlab::VersionInfo:0x0000000161bb5640 @major=14, @minor=6, @patch=1, @suffix_s="">,
 #<Gitlab::VersionInfo:0x0000000161bb5280 @major=14, @minor=7, @patch=0, @suffix_s="">,
 #<Gitlab::VersionInfo:0x0000000161bb58c0 @major=14, @minor=7, @patch=1, @suffix_s="">,
 #<Gitlab::VersionInfo:0x0000000161bb53c0 @major=14, @minor=8, @patch=0, @suffix_s="">,
 #<Gitlab::VersionInfo:0x0000000161bb5500 @major=14, @minor=8, @patch=1, @suffix_s="">,
 #<Gitlab::VersionInfo:0x0000000161bb5780 @major=14, @minor=8, @patch=2, @suffix_s="">,
 #<Gitlab::VersionInfo:0x0000000161bb6040 @major=14, @minor=8, @patch=3, @suffix_s="">,
 #<Gitlab::VersionInfo:0x0000000161bb5a00 @major=14, @minor=9, @patch=0, @suffix_s="">,
 #<Gitlab::VersionInfo:0x0000000161bb5b40 @major=14, @minor=9, @patch=1, @suffix_s="">,
 #<Gitlab::VersionInfo:0x0000000161bb5f00 @major=14, @minor=9, @patch=2, @suffix_s="">,
 #<Gitlab::VersionInfo:0x0000000161bb5c80 @major=14, @minor=10, @patch=0, @suffix_s="">,
 #<Gitlab::VersionInfo:0x0000000161bb5dc0 @major=14, @minor=10, @patch=1, @suffix_s="">,
 #<Gitlab::VersionInfo:0x0000000161bb6180 @major=15, @minor=0, @patch=0, @suffix_s="">,
 #<Gitlab::VersionInfo:0x0000000161bb62c0 @major=15, @minor=1, @patch=0, @suffix_s="">]

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Pedro Pombeiro

Merge request reports

Loading